[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-net-dev
Subject:    Re: [RFR] 8224635: Revert 8224256 and add back java/security/SecureClassLoader/DefineClass.java test
From:       Arthur Eubanks <aeubanks () google ! com>
Date:       2019-05-23 16:28:33
Message-ID: CAPW48sq4xS2oMVMvSOV_tMzNBmSTC7cr3i0T0n=y=4=-B_UJPA () mail ! gmail ! com
[Download RAW message or body]

On Thu, May 23, 2019 at 9:23 AM Sean Mullan <sean.mullan@oracle.com> wrote:

> Looks fine although you should update the 8224635 title to match the
> changeset.
>
Done

>
> Also, I assume you will file a followon bug for the original issue
> (JDK-8224256). I think a new bug must be filed instead of re-opening
> 8224256 because a changeset has already been pushed for it.
>
Yes I will file another bug to get this back in, this time making sure that
it passes on mach5 tier2 before submitting.

>
> --Sean
>
> On 5/23/19 12:08 PM, Arthur Eubanks wrote:
> > bug: https://bugs.openjdk.java.net/browse/JDK-8224635
> > webrev:
> http://cr.openjdk.java.net/~aeubanks/8224635/webrev.00/index.html
> >
> > Test java/security/SecureClassLoader/DefineClass.java is failing after
> > JDK-8224256
> > This change reverts the changes in JDK-8224256 and adds back in the test.
>

[Attachment #3 (text/html)]

<div dir="ltr"><div dir="ltr"><br></div><br><div class="gmail_quote"><div dir="ltr" \
class="gmail_attr">On Thu, May 23, 2019 at 9:23 AM Sean Mullan &lt;<a \
href="mailto:sean.mullan@oracle.com">sean.mullan@oracle.com</a>&gt; \
wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px \
0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Looks fine although \
you should update the 8224635 title to match the <br> \
changeset.<br></blockquote><div>Done  </div><blockquote class="gmail_quote" \
style="margin:0px 0px 0px 0.8ex;border-left:1px solid \
rgb(204,204,204);padding-left:1ex"> <br>
Also, I assume you will file a followon bug for the original issue <br>
(JDK-8224256). I think a new bug must be filed instead of re-opening <br>
8224256 because a changeset has already been pushed for it.<br></blockquote><div>Yes \
I will file another bug to get this back in, this time making sure that it passes on \
mach5 tier2 before submitting.  </div><blockquote class="gmail_quote" \
style="margin:0px 0px 0px 0.8ex;border-left:1px solid \
rgb(204,204,204);padding-left:1ex"> <br>
--Sean<br>
<br>
On 5/23/19 12:08 PM, Arthur Eubanks wrote:<br>
&gt; bug: <a href="https://bugs.openjdk.java.net/browse/JDK-8224635" rel="noreferrer" \
target="_blank">https://bugs.openjdk.java.net/browse/JDK-8224635</a><br> &gt; webrev: \
<a href="http://cr.openjdk.java.net/~aeubanks/8224635/webrev.00/index.html" \
rel="noreferrer" target="_blank">http://cr.openjdk.java.net/~aeubanks/8224635/webrev.00/index.html</a><br>
 &gt; <br>
&gt; Test java/security/SecureClassLoader/DefineClass.java is failing after <br>
&gt; JDK-8224256<br>
&gt; This change reverts the changes in  JDK-8224256 and adds back in the test.<br>
</blockquote></div></div>



[prev in list] [next in list] [prev in thread] [next in thread]