[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-net-dev
Subject:    Re: RFR: 8223880: Update sun/net/ftp/FtpURL.java and sun/net/ftp/FtpURLConnectionLeak.java to work w
From:       Vyom Tiwari <vyommani () gmail ! com>
Date:       2019-05-15 17:18:49
Message-ID: CAKysZ8ygh3a1caq_e7+z18Y+wau1k0xZCKw_E3rtkhzJvbowgg () mail ! gmail ! com
[Download RAW message or body]

Hi Daniel,

latest change looks good to me.

Even  i wanted to remove duplicate "FtpServer code" that we had copy and
pasted but somehow I did not got time do it.

Thanks,
Vyom

On Wed, May 15, 2019 at 7:08 PM Daniel Fuchs <daniel.fuchs@oracle.com>
wrote:

> Hi Vyom,
>
> On 15/05/2019 11:25, Vyom Tiwari wrote:
> > Hi Daniel,
> >
> > Changes looks good to me,
>
> Thanks!
>
> > as you said code is copied from one test to
> > another, i found FtpGetContent.java where same FtpServer code is
> > copied.  Are you planning to fix FtpGetContent.java as well  ?.
>
> Well - I wasn't intending to but it looks like a low
> hanging fruit. All other tests in that directory either
> do not use PASV or already support EPSV so it seems like
> a low hanging fruit to bundle the same change FtpGetContent.java
> and then we'll be done with it...
>
> Here it goes...
> http://cr.openjdk.java.net/~dfuchs/webrev_8223880/webrev.01/
>
> best regards,
>
> -- daniel
>
>
> >
> > Thanks,
> > Vyom
>
>

-- 
Thanks,
Vyom

[Attachment #3 (text/html)]

<div dir="ltr"><div>Hi Daniel,</div><div><br></div><div>latest change looks good to \
me. <br></div><div><br></div><div>Even   i wanted to remove duplicate &quot;FtpServer \
code&quot; that we had copy and pasted but somehow I did not got time do \
it.</div><div><br></div><div>Thanks,</div><div>Vyom<br></div></div><br><div \
class="gmail_quote"><div dir="ltr" class="gmail_attr">On Wed, May 15, 2019 at 7:08 PM \
Daniel Fuchs &lt;<a href="mailto:daniel.fuchs@oracle.com">daniel.fuchs@oracle.com</a>&gt; \
wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px \
0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Hi Vyom,<br> <br>
On 15/05/2019 11:25, Vyom Tiwari wrote:<br>
&gt; Hi Daniel,<br>
&gt; <br>
&gt; Changes looks good to me,<br>
<br>
Thanks!<br>
<br>
&gt; as you said code is copied from one test to <br>
&gt; another, i found FtpGetContent.java where same FtpServer code is <br>
&gt; copied.   Are you planning to fix FtpGetContent.java as well   ?.<br>
<br>
Well - I wasn&#39;t intending to but it looks like a low<br>
hanging fruit. All other tests in that directory either<br>
do not use PASV or already support EPSV so it seems like<br>
a low hanging fruit to bundle the same change FtpGetContent.java<br>
and then we&#39;ll be done with it...<br>
<br>
Here it goes...<br>
<a href="http://cr.openjdk.java.net/~dfuchs/webrev_8223880/webrev.01/" \
rel="noreferrer" target="_blank">http://cr.openjdk.java.net/~dfuchs/webrev_8223880/webrev.01/</a><br>
 <br>
best regards,<br>
<br>
-- daniel<br>
<br>
<br>
&gt; <br>
&gt; Thanks,<br>
&gt; Vyom<br>
<br>
</blockquote></div><br clear="all"><br>-- <br><div dir="ltr" \
class="gmail_signature">Thanks,<br>Vyom</div>



[prev in list] [next in list] [prev in thread] [next in thread]