[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-net-dev
Subject:    Re: RFR: 8222527: HttpClient doesn't send HOST header when tunelling HTTP/1.1 through http proxy
From:       Michael McMahon <michael.x.mcmahon () oracle ! com>
Date:       2019-04-18 15:03:59
Message-ID: 5CB891DF.9000303 () oracle ! com
[Download RAW message or body]

Thanks Daniel. All good.

- Michael.

On 17/04/2019, 18:00, Daniel Fuchs wrote:
> Hi Michael,
>
> On 17/04/2019 17:06, Michael McMahon wrote:
>> Looks fine. Though is the HOST_ALLOWED predicate actually needed in 
>> Utils.java?
>> Can you not do the negation inline directly in the HOST_RESTRICTED 
>> predicate?
>
> Good point!
>
> http://cr.openjdk.java.net/~dfuchs/webrev_8222527/webrev.01
>
> best regards,
>
> -- daniel
>
>>
>> - Michael.
>>
>> On 17/04/2019, 16:13, Daniel Fuchs wrote:
>>> Hi,
>>>
>>> Please find below a fix for:
>>>
>>> Issue:
>>> 8222527: HttpClient doesn't send HOST header when tunnelling HTTP/1.1
>>>          through http proxy
>>> https://bugs.openjdk.java.net/browse/JDK-8222527
>>>
>>> webrev:
>>> http://cr.openjdk.java.net/~dfuchs/webrev_8222527/webrev.00
>
[prev in list] [next in list] [prev in thread] [next in thread]