[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-net-dev
Subject:    Re: RFR: (8031737) rename jni_util.h macros for checking and returning on exceptions
From:       roger riggs <roger.riggs () oracle ! com>
Date:       2014-01-16 21:49:41
Message-ID: 52D853F5.8060500 () oracle ! com
[Download RAW message or body]

The webrev has been updated to revert the java.util.jar/pack CHECK_* 
macros and
to clean up the macro definitions in jni_util.h.

I plan to give the review some more time in case there are more comments 
coming.

Roger

> On Thu, Jan 16, 2014 at 8:26 AM, roger riggs <roger.riggs@oracle.com 
> <mailto:roger.riggs@oracle.com>> wrote:
> 
> Please review:
> 
> The native macros for checking and returning when exceptions
> are thrown have been renamed to include the "JNU_" prefix
> consistent with other functions in jni_util.h.
> 
> The macros have been renamed and existing uses in the jdk repository
> for networking, pack200, and have been updated. A jprt run has
> passed (except for unrelated failures).
> 
> webrev:
> http://cr.openjdk.java.net/~rriggs/webrev-jnu-check-rename-8031737/ \
> <http://cr.openjdk.java.net/%7Erriggs/webrev-jnu-check-rename-8031737/> 
> Thanks, Roger
> 
> [1] https://bugs.openjdk.java.net/browse/JDK-8031737
> 
> 


[Attachment #3 (text/html)]

<html>
  <head>
    <meta content="text/html; charset=UTF-8" http-equiv="Content-Type">
  </head>
  <body bgcolor="#FFFFFF" text="#000000">
    The webrev has been updated to revert the java.util.jar/pack CHECK_*
    macros and<br>
    to clean up the macro definitions in jni_util.h.<br>
     <br>
    I plan to give the review some more time in case there are more
    comments coming.<br>
    <br>
    Roger<br>
    <br>
    <blockquote
cite="mid:CA+kOe0-MgtH371LrHfi78WX+9Vm5oTDcbriopw2v5ti=RpgMsw@mail.gmail.com"
      type="cite">
      <div class="gmail_extra">
        <div class="gmail_quote">On Thu, Jan 16, 2014 at 8:26 AM, roger
          riggs <span dir="ltr">&lt;<a moz-do-not-send="true"
              href="mailto:roger.riggs@oracle.com" target="_blank">roger.riggs@oracle.com</a>&gt;</span>
          wrote:<br>
          <blockquote class="gmail_quote" style="margin:0 0 0
            .8ex;border-left:1px #ccc solid;padding-left:1ex">Please
            review:<br>
            <br>
            The native macros for checking and returning when exceptions<br>
            are thrown have been renamed to include the "JNU_" prefix<br>
            consistent with other functions in jni_util.h.<br>
            <br>
            The macros have been renamed and existing uses in the jdk
            repository<br>
            for networking, pack200, and have been updated. A jprt run
            has passed (except for unrelated failures).<br>
            <br>
            webrev:<br>
               <a moz-do-not-send="true"
href="http://cr.openjdk.java.net/%7Erriggs/webrev-jnu-check-rename-8031737/"
              target="_blank">http://cr.openjdk.java.net/~rriggs/webrev-jnu-check-rename-8031737/</a><br>
            <br>
            Thanks, Roger<br>
            <br>
            [1] <a moz-do-not-send="true"
              href="https://bugs.openjdk.java.net/browse/JDK-8031737"
              target="_blank">https://bugs.openjdk.java.net/browse/JDK-8031737</a><br>
          </blockquote>
        </div>
        <br>
      </div>
    </blockquote>
    <br>
  </body>
</html>


[prev in list] [next in list] [prev in thread] [next in thread]

Configure | About | News | Add a list | Sponsored by KoreLogic