[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-net-dev
Subject:    Code review: 7200720: crash in net.dll during NTLM authentication
From:       dmitry.samersoff () oracle ! com (Dmitry Samersoff)
Date:       2012-11-28 19:22:35
Message-ID: 50B6647B.6010102 () oracle ! com
[Download RAW message or body]

Michael,

NTLMAuthentication.java:

1. Copyright year should be either fixed or not changed
2. I think it's better to remove bug id from comments and replace
   comment like
      // MMM 7200720 ??
   to something better.

NTLMAuthSequence.c

1. Copyright ...


Otherwise looks good for me.

-Dmitry


On 2012-11-28 17:47, Michael McMahon wrote:
> On 23/11/12 16:16, Alan Bateman wrote:
>> On 23/11/2012 15:59, Michael McMahon wrote:
>>> Could I get the following change reviewed please?
>>> There was a crash caused by accessing freed memory when
>>> authentication was repeated in the same HttpURLConnection instance/
>>>
>>> http://cr.openjdk.java.net/~michaelm/7200720/webrev.1/
>> I haven't reviewed the changes but I notice this changes the build
>> slightly so I just wonder if you've checked the new build.
>>
>> -Alan
> 
> just checked the new build on Linux and it's fine.
> There are a couple of other fixes that will follow this one
> related to this problem. But, I'd like to go ahead and push this one first
> if possible
> 
> - Michael


-- 
Dmitry Samersoff
Oracle Java development team, Saint Petersburg, Russia
* Give Rabbit time, and he'll always get the answer

[prev in list] [next in list] [prev in thread] [next in thread]