[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-net-dev
Subject:    RFR 8003833: Spurious NPE from Socket.getIn/OutputStream
From:       dmitry.samersoff () oracle ! com (Dmitry Samersoff)
Date:       2012-11-27 12:18:20
Message-ID: 50B4AF8C.4050509 () oracle ! com
[Download RAW message or body]

Looks good for me.
-Dmitry

On 2012-11-27 15:44, Chris Hegarty wrote:
> This is a longstanding bug in the Socket code that was only noticed
> recently as a result of some test changes that Daniel pushed in the nio
> area.
> 
> There is a very small window in
> AbstractPlainSocketImpl.getIn/OutputStream where isClosedOrPending()
> grabs the fdLock to check if the socket is closed, or not, and the
> construction of the in/output stream, where another thread may
> asynchronously close the socket.
> 
> http://cr.openjdk.java.net/~chegar/8003833/webrev.00/webrev/
> 
> -Chris.


-- 
Dmitry Samersoff
Oracle Java development team, Saint Petersburg, Russia
* Give Rabbit time, and he'll always get the answer

[prev in list] [next in list] [prev in thread] [next in thread]