[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-nashorn-dev
Subject:    Re: RFR: 8131017: jshell tool: pasting code with tabs invokes tab completion
From:       Marcus Lagergren <marcus () lagergren ! net>
Date:       2016-05-24 9:51:04
Message-ID: 764A304A-8A9A-4D53-BD12-BB3830EE6834 () lagergren ! net
[Download RAW message or body]

+1

> On 20 May 2016, at 12:44, Jan Lahoda <jan.lahoda@oracle.com> wrote:
> 
> Please review.
> 
> Problem: when pasting code that contains tab characters into both jshell and jjs, \
> the tab completion gets invoked on tabs instead of using the tab character itself. 
> The proposed solution is to set setCopyPasteDetection(true) on jline's \
> ConsoleReader, which should enable jline's copy-paste detection, and avoid invoking \
> the tab completion on paste. A limitation of the detection is that it cannot detect \
> trailing tab characters, only can detect tab character followed by at least one \
> more character. I hope that shouldn't be a big problem. 
> Bug:
> https://bugs.openjdk.java.net/browse/JDK-8131017
> 
> Webrev - langtools:
> http://cr.openjdk.java.net/~jlahoda/8131017/langtools/webrev.00/
> 
> Webrev - nashorn:
> http://cr.openjdk.java.net/~jlahoda/8131017/nashorn/webrev.00/
> 
> Thanks,
> Jan


[prev in list] [next in list] [prev in thread] [next in thread]