[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-nashorn-dev
Subject:    Re: RFR 8047728: (function(x){var o={x:0}; with(o){delete x} return o.x})() evaluates to 0 instead o
From:       Marcus Lagergren <marcus.lagergren () oracle ! com>
Date:       2014-06-24 3:31:13
Message-ID: C62361FF-00E5-46AC-A1C5-B0351A2EC62F () oracle ! com
[Download RAW message or body]

+1. 

A comment above the line

+            final boolean failDelete = strictMode || (!symbol.isScope() && \
(symbol.isParam() || (symbol.isVar() && !symbol.isProgramLevel())));

explaining the logic, would be helpful, I guess. It is getting a bit convoluted.


Can you add a TODO in the comment in LocalVariableTypesCalculator so it shows up in \
the margin of IDEs? 

On 23 Jun 2014, at 14:20, A. Sundararajan <sundararajan.athijegannathan@oracle.com> \
wrote:

> Please review http://cr.openjdk.java.net/~sundar/8047728/
> 
> Thanks
> -Sundar


[prev in list] [next in list] [prev in thread] [next in thread]