[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-mlvm-dev
Subject:    Re: RFR(XS) : 8055269 : java/lang/invoke/MethodHandles/CatchExceptionTest.java
From:       Vladimir Ivanov <vladimir.x.ivanov () oracle ! com>
Date:       2015-05-19 15:50:04
Message-ID: 555B5BAC.2040006 () oracle ! com
[Download RAW message or body]

Looks good then!

Best regards,
Vladimir Ivanov

On 5/19/15 12:35 PM, Igor Ignatyev wrote:
> Vladimir,
>
> thank you for review.
>
> regarding slot consumption calculation, to get parameters limited by
> slot number, the test uses Helper.getParams method which implements this
> calculation
> (test/lib/testlibrary/jsr292/com/oracle/testlibrary/jsr292/Helper.java:133-148)
>
>
> --
> Igor
>
> On 05/18/2015 09:03 PM, Vladimir Ivanov wrote:
>> Ok, now I see long.class in the list :-)
>>
>> Does the test checks 255 limit on slots or logical arguments? It should
>> check slot size, but I don't see logic for computing slot consumption
>> for generated signatures.
>>
>> Best regards,
>> Vladimir Ivanov
>>
>> On 5/18/15 8:58 PM, Vladimir Ivanov wrote:
>>> Igor,
>>>
>>> Looks good.
>>>
>>> You don't need to bother computing slot size for a signature since you
>>> use only 1-slot types, do you?
>>>
>>> test/java/lang/invoke/MethodHandles/CatchExceptionTest.java:
>>>          Class<?> classes[] = {
>>>                  Object.class,
>>>                  long.class,
>>>                  int.class,
>>>                  byte.class,
>>>                  Integer[].class,
>>>                  double[].class,
>>>                  String.class,
>>>
>>> Best regards,
>>> Vladimir Ivanov
>>>
>>> On 5/18/15 8:51 PM, Igor Ignatyev wrote:
>>>> http://cr.openjdk.java.net/~iignatyev/8055269/webrev.00/
>>>> 23 lines changed: 8 ins; 9 del; 6 mod
>>>>
>>>> Hi all,
>>>>
>>>> please review the tiny fix for CatchExceptionTest test.
>>>>
>>>> problem: the tests generates a target w/ 255 parameters, so a
>>>> corresponding handler should have 256 parameters. that violates
>>>> restrictions.
>>>>
>>>> fix: limit target's arity by 254
>>>>
>>>> side changes:
>>>>   - cover a handler w/o dropped arguments case
>>>>   - fix a typo in a comment
>>>>   - always print maxArg, maxDrop and generated parameters' classes
>>>>   - print test properties in runTest method instead of ctor.
>>>>
>>>> testing: locally, w/ and w/o -Dthorough
>>>> JBS: https://jbs.oracle.com/bugs/browse/JDK-8055269
>>>>
_______________________________________________
mlvm-dev mailing list
mlvm-dev@openjdk.java.net
http://mail.openjdk.java.net/mailman/listinfo/mlvm-dev
[prev in list] [next in list] [prev in thread] [next in thread]