[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-jtreg-dev
Subject:    Re: RFR: CODETOOLS-7903264: Full support for JUnit tests
From:       Iris Clark <iris () openjdk ! org>
Date:       2022-08-26 4:11:12
Message-ID: QsCHbyPrGp43Kc1A0BHvTU-Sk3c_XSYbOL-UUy4VOns=.649be78f-31b3-4f39-a8e4-cc1e5d07062c () github ! com
[Download RAW message or body]

On Fri, 26 Aug 2022 01:56:51 GMT, Jonathan Gibbons <jjg@openjdk.org> wrote:

> Please review a medium-size patch to upgrade the support for running directories of \
> Unit tests. This is primarily in the jtreg front end, either cloning or sharing and \
> then modifying the support for directories of TestNG tests. The back end already \
> supports direct use of JUnit for `@run junit` and the new code leverages that work. \
>  There is one tweak to the JUnit back-end, to enable the generation of summary \
> reports. To that end, the class `TestNGSummaryReporter` has morphed into \
> `SummaryReporter` with internal subtypes for `JUnit` and `TestNG`. That refactoring \
> was too much for git to recognize, and so the change shows up as "old file deleted; \
> new file added". 
> Two new groups of tests are added, which are just modified copies of existing \
> TestNG tests, to verify that JUnit support is effectively equivalent to TestNG \
> support.

Very nice!

-------------

Marked as reviewed by iris (Reviewer).

PR: https://git.openjdk.org/jtreg/pull/107


[prev in list] [next in list] [prev in thread] [next in thread]