[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-jtreg-dev
Subject:    Re: RFR: 7902912: Update IntelliJ Plugin build Readme [v2]
From:       Thomas Stuefe <stuefe () openjdk ! java ! net>
Date:       2021-04-30 13:57:57
Message-ID: OYg3_TICndghVuWa5Wp82-BfSJNvEANXIz_4q_gqmEQ=.25eaaacc-55fb-4b5c-a405-8bf317c239aa () github ! com
[Download RAW message or body]

On Fri, 30 Apr 2021 13:42:20 GMT, Thomas Stuefe <stuefe@openjdk.org> wrote:

> > Hi, may I have reviews for this small documentation fix please? I am not a \
> > CODETOOLS committer so I may need someone to sponsor this fix. 
> > Since I just built the intellij plugin in 2020.3, I stumbled about a couple of \
> > ambiguous infos which are not immediately clear to outsiders. 
> > -> some UI features changed in Intellij
> > -> Clarified the meaning of JTREG_HOME
> > -> One thing I was not sure about was the required SDK level to build the plugin. \
> > The documentation says "Any JDK 8 is fine" which I took as "JDK8 is required" - \
> > proceeded to download JDK 8 but then I was unable to choose this JDK as a SDK for \
> > the IDEA JDK. It was, however, happy with a JDK 15 I gave it, and proceeded to \
> > build the plugin without any issues. Therefore I changed the sentence to "Any JDK \
> > 8++ is a fine choice".
> 
> Thomas Stuefe has updated the pull request incrementally with one additional commit \
> since the last revision: 
> Update plugins/idea/README.md
> 
> Co-authored-by: Maurizio Cimadamore <54672762+mcimadamore@users.noreply.github.com>

Ah, you are right... This got so much easier with Skara.

-------------

PR: https://git.openjdk.java.net/jtreg/pull/8


[prev in list] [next in list] [prev in thread] [next in thread]