[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-jmx-dev
Subject:    Re: jmx-dev RFR: 8188784: javax/management/notification/BroadcasterSupportDeadlockTest.java - TEST
From:       Kevin Walls <kevinw () openjdk ! org>
Date:       2024-04-16 10:24:09
Message-ID: VR9cYyLlSnYr_daO-gDaRRsbulEPkcRSrHRSkCYqmXg=.fc4d3054-7b4e-4554-9886-e8bf8b52a38f () github ! com
[Download RAW message or body]

On Tue, 16 Apr 2024 09:26:58 GMT, Kevin Walls <kevinw@openjdk.org> wrote:

> > This test incorrectly fails, although rarely, thinking its "thread 2" has \
> > deadlocked. A change of sleep will likely fix this, but there are other issues, \
> > so cleaning up the test a little. 
> > Remove the probe for the ManagementFactory class, to check we are on jdk5 or \
> > later. 8-) 
> > When sleeping, sleep 100, not 1ms, we don't need to spin fast and actually race \
> > with the other thread. 
> > We have a 1000 iteration loop, but don't seem to use it.  We only check once then \
> > either return (pass), fail, or break (which is also fail).  Use the loop to check \
> > for the status change, which is likely what was intended. 
> > Show the stackframes on all failures.
> 
> Kevin Walls has updated the pull request with a new target base due to a merge or a \
> rebase. The incremental webrev excludes the unrelated changes brought in by the \
> merge/rebase. The pull request contains three additional commits since the last \
> revision: 
> - Remove System.exit calls
> - Merge remote-tracking branch 'upstream/master' into \
>                 8188784_BroadcasterSupportDeadlockTest
> - 8188784: javax/management/notification/BroadcasterSupportDeadlockTest.java - TEST \
> FAILED: deadlock

Thanks for the reviews!

-------------

PR Comment: https://git.openjdk.org/jdk/pull/18687#issuecomment-2058745011


[prev in list] [next in list] [prev in thread] [next in thread]