From openjdk-jmx-dev Wed Nov 30 14:46:06 2022 From: Daniel Fuchs Date: Wed, 30 Nov 2022 14:46:06 +0000 To: openjdk-jmx-dev Subject: Re: jmx-dev RFR: 8297794: Deprecate JMX Management Applets for Removal Message-Id: X-MARC-Message: https://marc.info/?l=openjdk-jmx-dev&m=166981915626607 On Wed, 30 Nov 2022 14:24:36 GMT, Kevin Walls wrote: > MLetObjectInputStream and MLetParser are not public classes, so thinking they are not part of the public API we need to deprecate before removal. Whether a class is public exported or not has no real relationship with whether it should have the `@Deprecated` annotation or not. It is better to add the `@Deprecated` annotation eagerly to all classes that are part of the feature being deprecated, if they are only used for the implementation of that feature, and if the thinking is that they would be removed if the feature is removed. Plus it usually simplifies things as it usually minimizes the places where you need to suppress warnings. ------------- PR: https://git.openjdk.org/jdk/pull/11430