[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-jmx-dev
Subject:    Re: jmx-dev RFR: 8295729: Add jcheck whitespace checking for properties files [v3]
From:       Magnus Ihse Bursie <ihse () openjdk ! org>
Date:       2022-11-29 19:26:36
Message-ID: D-_pSm7C9d1Wdx-g6Tz0PTX_7CgFMitkkGCV907jv_8=.77ff6af8-466b-42ab-a015-73589600dab1 () github ! com
[Download RAW message or body]

On Mon, 24 Oct 2022 19:21:07 GMT, Magnus Ihse Bursie <ihse@openjdk.org> wrote:

> > Properties files is essentially source code. It should have the same whitespace \
> > checks as all other source code, so we don't get spurious trailing whitespace \
> > changes. 
> > With the new Skara jcheck, it is possible to increase the coverage of the \
> > whitespace checks (in the old mercurial version, this was more or less \
> > impossible). 
> > The only manual change is to `.jcheck/conf`. All other changes were made by \
> > running `find . -type f -iname "*.properties" | xargs gsed -i -e 's/[ \t]*$//'`.
> 
> Magnus Ihse Bursie has updated the pull request incrementally with two additional \
> commits since the last revision: 
> - Revert "Remove check for .properties from jcheck"
> 
> This reverts commit c91fdaa19dc06351598bd1c0614e1af3bfa08ae2.
> - Change trailing space and tab in values to unicode encoding

Yes bot, I know. I'll need to split this up into multiple steps, but please keep this \
open for a while more. Thank you.

-------------

PR: https://git.openjdk.org/jdk/pull/10792


[prev in list] [next in list] [prev in thread] [next in thread]