[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-jmx-dev
Subject:    Re: jmx-dev RFR: 8286441: Remove mode parameter from jdk.internal.perf.Perf.attach()
From:       Ioi Lam <iklam () openjdk ! java ! net>
Date:       2022-05-11 19:29:57
Message-ID: LvpF1pmJ9MSZD7OYitX5Q_jy2uJSNG1cUZWY3KywhyU=.8080bd6b-2b9d-4992-81cf-39d8ed158cf9 () github ! com
[Download RAW message or body]

On Tue, 10 May 2022 20:03:45 GMT, Alan Bateman <alanb@openjdk.org> wrote:

> > The `mode` parameter for ` jdk.internal.perf.Perf.attach()` has never supported \
> > the value `"rw"` since the source code was imported to the openjdk repo more than \
> > 15 years ago. In fact HotSpot throws `IllegalArgumentException` when such a mode \
> > is specified. 
> > It's unlikely such a mode will be required for future enhancements. Support for \
> > `"rw"` is removed. The "mode" parameter is also removed, since now `"r"` is the \
> > only supported mode. 
> > I also cleaned up related code in the JDK and HotSpot.
> > 
> > Testing:
> > - Passed tiers 1 ~ 5
> 
> I skimmed through the changes and I think they look okay. In the distant past there \
> were tools outside of the JDK that used the jvmstat API directly. It's possible \
> that VisualVM still does but it would only compile/run if --add-exports is used to \
> export the sun.jvmstat.* packages. So it might be that dropping the parameter from \
> a method in RemoteHost is noticed and I think that is okay because this package is \
> not exported and is not meant to be used by code outside of the JDK.

Thanks to @AlanBateman and @cl4es for the review.

-------------

PR: https://git.openjdk.java.net/jdk/pull/8622


[prev in list] [next in list] [prev in thread] [next in thread]