[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-jmx-dev
Subject:    Re: jmx-dev RFR 7112404: 2 tests in java/lang/management/ManagementFactory fails with G1 because exp
From:       Mandy Chung <mandy.chung () oracle ! com>
Date:       2013-10-22 19:38:56
Message-ID: 5266D450.5050506 () oracle ! com
[Download RAW message or body]

On 10/21/13 7:46 AM, Jaroslav Bachorik wrote:
> Please, review this simple test fix.
>
> Issue:  https://bugs.openjdk.java.net/browse/JDK-7112404
> Webrev: http://cr.openjdk.java.net/~jbachorik/7112404/webrev.00
>

Looks okay to me.

Mandy

> The tests assume the MemoryUsage#commited values to be positive (>0) 
> while according to the MemoryUsage only negative values are invalid. 
> Therefore the tests should check and fail only when 
> MemoryUsage#commited is < 0.
>
> Thanks,
>
> -JB-

[prev in list] [next in list] [prev in thread] [next in thread]