[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-jmx-dev
Subject:    Re: jmx-dev RFR: 6804470 JvmstatCountersTest.java test times out on slower machines
From:       Jaroslav Bachorik <jaroslav.bachorik () oracle ! com>
Date:       2013-10-15 13:01:32
Message-ID: 525D3CAC.1030905 () oracle ! com
[Download RAW message or body]

On 14.10.2013 20:11, Alan Bateman wrote:
> On 14/10/2013 16:21, Jaroslav Bachorik wrote:
>> Please, review the following simple change.
>>
>> The test times out on slower machines and I was able to reproduce the
>> failure even on a normally fast machine using the fastdebug build. The
>> timeout does not occur on every run - more like once in 10-15 runs.
>>
>> There is nothing really wrong with the test - it just takes rather
>> long time to obtain the jvmstat counters. The remedy is to specify a
>> longer timeout and see if it is enough. I am using 10 minutes for the
>> timeout in the patch.
>>
>> Issue : https://bugs.openjdk.java.net/browse/JDK-6804470
>> Webrev: http://cr.openjdk.java.net/~jbachorik/6804470/webrev.00
>>
>> Thanks,
>>
>> -JB-
> This looks okay to me but if someone is testing a fastdebug build then
> they really need to specify the -timeoutFactor option to jtreg so as to
> scale the timeouts.

Just FYI - the SQE does use timeoutFactor 8x for the fastdebug runs. I 
hope this will be enough in combination with the extended timeout in the 
tests.

-JB-

>
> -Alan.

[prev in list] [next in list] [prev in thread] [next in thread]