[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-jigsaw-dev
Subject:    Re:
From:       mandy chung <mandy.chung () oracle ! com>
Date:       2017-08-31 18:39:13
Message-ID: 3d2e18d2-2e90-c301-c16e-bbd353bad48a () oracle ! com
[Download RAW message or body]

Hi Nicolai,

The `--generate-module-info` and `--generate-open-module` options take 
an output directory argument and generates module-info.java (source 
file) in the output directory, one per each specified JAR file on the 
command-line.

I agree that this is not ideal and `--generate-module-declarations` is a 
good option name.   Having a second thought, a better alternative might 
be to add --output <dir> option so that --generate-module-declarations 
could specify an optional argument `open`.

We can introduce new option names in a future release.

Mandy

On 8/30/17 11:43 PM, Nicolai Parlog wrote:
>   Hi!
>
> I guess it's too late to change that now, but I find two of JDeps
> command line options have really unfortunate names:
>
> `--generate-module-info`
>
> * module-info is very colloquial, is this term used anywhere else?
> * it's singular, which is of course grammatically correct but
>    _really_ weird - it generates many module declarations (infos?)
>    after all
>
> `--generate-open-module`
>
> * this should definitely be plural
> * where did the "-info" go - is it not needed here?
>
> I think `--generate-modules`/`--generate-open-modules` would be nice and
> comparatively succinct. There is a slight discomfort because nobody is
> actually creating modules, so
> `--generate-module-declarations`/`--generate-open-module-declarations`
> would be more precise, but obviously much longer.
>
>   so long ... Nicolai
>
>
>

[prev in list] [next in list] [prev in thread] [next in thread]