[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-i18n-dev
Subject:    Re: <i18n dev> RFR: 8280474: Garbage value passed to getLocaleInfoWrapper in HostLocaleProviderAdapt
From:       Daniel =?UTF-8?B?SmVsacWEc2tp?= <djelinski () openjdk ! java ! net>
Date:       2022-01-24 8:09:04
Message-ID: 6H7ByIE0exrvC76VNJncAIeXIno7GvxJeztKwFw-dFM=.0b40544c-ea07-4bd7-a67b-6af9799ab4e8 () github ! com
[Download RAW message or body]

On Fri, 21 Jan 2022 19:28:21 GMT, Daniel Jeliński <djelinski@openjdk.org> wrote:

> Reported by clang-tidy. Verified manually by running
> 
> Calendar c = Calendar.getInstance();
> System.out.println (c.getDisplayNames(Calendar.MONTH, Calendar.SHORT_STANDALONE, \
> Locale.getDefault())); 
> with `-Djava.locale.providers=HOST`
> 
> Without the fix the WINAPI functions fail, and [this \
> block](https://github.com/openjdk/jdk/blame/739769c8fc4b496f08a92225a12d07414537b6c0/src/java.base/windows/native/libjava/HostLocaleProviderAdapter_md.c#L857) \
> is never entered. With the fix this block is entered and sensible values are stored \
> in the returned array. 
> No test because the observable effect with and without the fix was the same; \
> apparently there's a fallback to another provider that works.

Thanks!

-------------

PR: https://git.openjdk.java.net/jdk/pull/7184


[prev in list] [next in list] [prev in thread] [next in thread]