[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-i18n-dev
Subject:    Re: <i18n dev> RFR: 8268113: Re-use Long.hashCode() where possible [v11]
From:       Claes Redestad <redestad () openjdk ! java ! net>
Date:       2021-08-02 11:22:44
Message-ID: 1tMR5seQ0nt1U7RbpVx7RNgvMl9Eov8JRVmmjASa5HQ=.b4f65b78-74ee-457b-b9db-e1acbfff80c2 () github ! com
[Download RAW message or body]

On Mon, 26 Jul 2021 08:27:14 GMT, Сергей Цыпанов \
<github.com+10835776+stsypanov@openjdk.org> wrote:

> > There is a few JDK classes duplicating the contents of Long.hashCode() for hash \
> > code calculation. They should explicitly delegate to Long.hashCode().
> 
> Сергей Цыпанов has updated the pull request with a new target base due \
> to a merge or a rebase. The incremental webrev excludes the unrelated changes \
> brought in by the merge/rebase. The pull request contains 13 additional commits \
> since the last revision: 
> - Merge branch 'master' into 8268113
> - 8270160 Revert changes in BitSet.hashCode
> - Merge branch 'master' into 8268113
> - 8270160 Revert changes in BitSet.hashCode
> - Merge branch 'master' into 8268113
> - Merge branch 'master' into 8268113
> - Merge branch 'master' into 8268113
> - Merge branch 'master' into 8268113
> - Merge branch 'master' into 8268113
> - Merge branch 'master' into 8268113
> - ... and 3 more: https://git.openjdk.java.net/jdk/compare/1d801fa0...bd762b7d

All changes look good to me, though 3rd party sources like xerces/.../DoubleDV.java \
should probably be dealt with in the upstream first. @AlanBateman probably knows who \
maintains and downstreams this usually (or whether we are now practically maintaining \
a fork of xerces)?

-------------

Marked as reviewed by redestad (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/4309


[prev in list] [next in list] [prev in thread] [next in thread]