[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-hotspot-runtime-dev
Subject:    Re: RFR: 8330647: Two CDS tests fail with -UseCompressedOops and UseSerialGC/UseParallelGC [v2]
From:       Calvin Cheung <ccheung () openjdk ! org>
Date:       2024-05-17 16:38:02
Message-ID: jna740z4C6SIHzzIh2-k23AFILql6jQgksUfqsSslAo=.70eeb7a8-44e5-4144-bab8-ad72ea1c6292 () github ! com
[Download RAW message or body]

On Fri, 17 May 2024 02:19:15 GMT, David Holmes <dholmes@openjdk.org> wrote:

> Can't the code that implements the `@requires` check also check for that property?

Yes, I've reverted the changes in the tests and added the checking of the \
`test.cds.runtime.options` property in `VMProps.java`. Also, instead of just checking \
for null value, it checks for if any of the options conflicts is not compatible with \
writing Java heap objects into the CDS archive.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/19274#issuecomment-2117970033


[prev in list] [next in list] [prev in thread] [next in thread]