[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-hotspot-runtime-dev
Subject:    Integrated: 8332327: Return _methods_jmethod_ids field back in VMStructs
From:       Andrei Pangin <apangin () openjdk ! org>
Date:       2024-05-17 9:43:12
Message-ID: txwAZs3-4BVSjgTA3lMJK74OomxJ8E777gdqJ4lZi3k=.e5fee733-140f-460f-a6e6-6324c6e214fa () github ! com
[Download RAW message or body]

On Wed, 15 May 2024 21:12:03 GMT, Andrei Pangin <apangin@openjdk.org> wrote:

> The fix for [JDK-8313332](https://bugs.openjdk.org/browse/JDK-8313332) has \
> [removed](https://github.com/openjdk/jdk/commit/21867c929a2f2c961148f2cd1e79d672ac278d27#diff-7d448441e80a0b784429d5d8aee343fcb131c224b8ec7bc70ea636f78d561ecd
>  ) `InstanceKlass::_methods_jmethod_ids` field from VMStructs.
> 
> This broke [async-profiler](https://github.com/async-profiler/async-profiler/), \
> since the profiler needs this field to obtain jmethodID in some corner cases. 
> There was no actual need for removal, as the field is still there in InstanceKlass. \
> So, I propose to return the field back to restore the broken functionality of \
> async-profiler. This is a no risk change, because it only exports an offset of one \
> field and does not affect the JVM otherwise.

This pull request has now been integrated.

Changeset: d84a8fd8
Author:    Andrei Pangin <apangin@openjdk.org>
Committer: Aleksey Shipilev <shade@openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/d84a8fd8762fe9448e73d75ec9dc8c4876b1a709
                
Stats:     1 line in 1 file changed: 1 ins; 0 del; 0 mod

8332327: Return _methods_jmethod_ids field back in VMStructs

Reviewed-by: cjplummer, sspitsyn, coleenp, shade

-------------

PR: https://git.openjdk.org/jdk/pull/19254


[prev in list] [next in list] [prev in thread] [next in thread]