[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-hotspot-runtime-dev
Subject:    Re: RFR: 8332237: [nmt] Remove the need for ThreadStackTracker::track_as_vm()
From:       Thomas Stuefe <stuefe () openjdk ! org>
Date:       2024-05-16 14:58:13
Message-ID: c3-q54qt-1IRPRK9vv_ZA7jword6XsD-AB_Am0UKWfo=.e6201d41-6172-4707-88ee-fa28a0300941 () github ! com
[Download RAW message or body]

On Thu, 16 May 2024 10:52:52 GMT, Johan Sjölen <jsjolen@openjdk.org> wrote:

> > > Hi,
> > > 
> > > I'm very happy to see this simplification being made in NMT, thank you for \
> > > doing this! Code looks good to me, have you run this through any non-AIX CI?
> > 
> > Yes, it ran the full gamut of tests over at SAP. They test on a ton of platforms.
> 
> > > Hi,
> > > I'm very happy to see this simplification being made in NMT, thank you for \
> > > doing this! Code looks good to me, have you run this through any non-AIX CI?
> > 
> > Yes, it ran the full gamut of tests over at SAP. They test on a ton of platforms.
> 
> Ship it! (after receiving another review)

Thanks @jdksjolen and @afshin-zafari . I'll wait the obligatory 24, and maybe for \
@zhengyu123 to chime in in case I got some of the history wrong.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/19231#issuecomment-2115481641


[prev in list] [next in list] [prev in thread] [next in thread]