[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-hotspot-runtime-dev
Subject:    Re: RFR: 8331858: [nmt] VM.native_memory statistics should work in summary mode [v2]
From:       Sonia Zaldana Calles <szaldana () openjdk ! org>
Date:       2024-05-14 14:04:02
Message-ID: Jlltod1ANKfzAKNE2X6mO549p2jDjtQKE8cP-FcX6uk=.28e150b2-cf6c-4469-ad9e-9ac12a14b866 () github ! com
[Download RAW message or body]

On Tue, 14 May 2024 10:00:59 GMT, Johan Sjölen <jsjolen@openjdk.org> wrote:

> > Hi @jdksjolen, are you referring to the indentation printing the tracking level? \
> > I can definitely revert the indentation there.
> 
> Aha, I see, you added an `if` branch there! It was hard to see with the styling \
> change on top. I think it's fine as is.

No worries, thanks for the review!

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19179#discussion_r1600100062


[prev in list] [next in list] [prev in thread] [next in thread]