[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-hotspot-runtime-dev
Subject:    Re: RFR: 8330066: HeapDumpPath and HeapDumpGzipLevel VM options do not mention HeapDumpBeforeFullGC 
From:       David Holmes <dholmes () openjdk ! org>
Date:       2024-05-14 9:59:02
Message-ID: 3LosTENVEPXiSEynSv-6wDNR_ces65ID9d0AuVJQ9MY=.b8481fb0-1c6c-4873-b538-f48240595863 () github ! com
[Download RAW message or body]

On Tue, 14 May 2024 01:53:20 GMT, Alex Menkov <amenkov@openjdk.org> wrote:

> > The fix updates descriptions of `HeapDumpPath`/`HeapDumpGzipLevel` and \
> > `HeapDumpBeforeFullGC`/`HeapDumpAfterFullGC`/`HeapDumpOnOutOfMemoryError` VM \
> > options
> 
> Alex Menkov has updated the pull request incrementally with one additional commit \
> since the last revision: 
> align

Updates look good.

FWIW the Java command reference doesn't mention the before/after full GC flags \
either.

-------------

Marked as reviewed by dholmes (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/19224#pullrequestreview-2054872345


[prev in list] [next in list] [prev in thread] [next in thread]