[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-hotspot-runtime-dev
Subject:    Integrated: 8315431: ArchiveHeapWriter::get_filler_size_at() cannot handle buffer expansion
From:       Ioi Lam <iklam () openjdk ! org>
Date:       2024-05-10 20:37:18
Message-ID: AQNRuHvR49oc79S0N8xS7dD5tDRlx4W1oIYfJq1dtmQ=.f7fdc4d3-97df-4474-915e-1384af5b6220 () github ! com
[Download RAW message or body]

On Tue, 23 Apr 2024 15:47:46 GMT, Ioi Lam <iklam@openjdk.org> wrote:

> In `ArchiveHeapWriter::maybe_fill_gc_region_gap()`:
> 
> - The address of `filler` will change if the buffer (which is a GrowableArrayCHeap) \
>                 expands.
> - Instead of storing the address, we store the offset of `filler` from the \
> beginning of the buffer. This offset will not change even if the buffer expands.

This pull request has now been integrated.

Changeset: 5e8e8ef6
Author:    Ioi Lam <iklam@openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/5e8e8ef6565e82a23626fe16893f93870dae1012
                
Stats:     6 lines in 1 file changed: 2 ins; 0 del; 4 mod

8315431: ArchiveHeapWriter::get_filler_size_at() cannot handle buffer expansion

Reviewed-by: matsaave, ccheung

-------------

PR: https://git.openjdk.org/jdk/pull/18920


[prev in list] [next in list] [prev in thread] [next in thread]