[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-hotspot-runtime-dev
Subject:    Re: RFR: 8328111: Convert Runtime tests to use the ClassFile API instead of ASM [v20]
From:       Oussama Louati <duke () openjdk ! org>
Date:       2024-04-29 16:36:08
Message-ID: _5Naioo7QkmsXcnzT3VfTEn5qpRq2yefj1Mnxnvhpa0=.c6ae192b-4d07-4cf5-abf8-baa364223807 () github ! com
[Download RAW message or body]

On Mon, 1 Apr 2024 13:00:03 GMT, Oussama Louati <duke@openjdk.org> wrote:

> > The main goal pull request migrate the existing tests to utilize the new \
> > ClassFile API instead of the ASM library. The use of ASM has served us well in \
> > the past, but maintaining it has its costs and limitations. 
> > ### **Cost of Maintaining ASM Library:**
> > 
> > - _Risk of Changes:_ The ASM library is an external dependency, and updates or \
> > changes in its APIs can introduce unforeseen issues or require significant code \
> >                 modifications in our tests.
> > - _Lack of Reviewers:_ As the ASM library evolves, finding reviewers familiar \
> > with its intricacies becomes challenging, leading to delays in reviewing and \
> > merging changes. 
> > ### **Reasons for Migration:**
> > 
> > - _Stability and Consistency:_ Utilizing the ClassFile API ensures stability and \
> > compatibility with the Java platform, reducing the risk of compatibility issues \
> >                 due to external library changes.
> > - _Sustainability:_ The ClassFile API is a standard part of Java, making it \
> >                 easier to find reviewers and maintain code consistency across \
> >                 test suites.
> > - _Future Compatibility:_ As Java evolves, relying on native Java APIs like the \
> > ClassFile API ensures future compatibility and reduces technical debt. 
> > ### **Concerns Addressed:**
> > 
> > - Risk of Changes: By migrating to a standard Java API, we mitigate the risks \
> > associated with external library changes and ensure smoother maintenance and \
> >                 updates in the future.
> > - Backporting and Compatibility: The use of native Java APIs allows for easier \
> > backporting of test fixes and ensures compatibility across Java versions, \
> > including preview releases. 
> > > **Please note:** We won't integrate this PR until we've fully finalized the \
> > > ClassFile API and all tests utilize it.
> 
> Oussama Louati has updated the pull request incrementally with one additional \
> commit since the last revision: 
> resolve review comments

Adding comment to reset inactivity time

-------------

PR Comment: https://git.openjdk.org/jdk/pull/18271#issuecomment-2083179557


[prev in list] [next in list] [prev in thread] [next in thread]