[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-hotspot-runtime-dev
Subject:    Re: RFR: 8325207: Support out of order classpath in AppCDS.
From:       Andrey Turbanov <aturbanov () openjdk ! org>
Date:       2024-04-26 11:23:09
Message-ID: _Envq1r2rTIocm5MwnEI4cSExu3NWHBcT0h2xMdcLTQ=.c34af140-ede9-42ed-aaa2-a0c5265bc842 () github ! com
[Download RAW message or body]

On Mon, 5 Feb 2024 07:29:17 GMT, lingjun-cg <duke@openjdk.org> wrote:

> When a Java application runs with a wildcard classpath like this:
> `java -cp "lib/*"`
> JVM will expand "lib/*" to the actual jar list, but the order of the jar list may \
> be different on different hosts, which depends on the underlying filesystem. 
> Dumping the AppCDS archive is usually done on a CI/CD environment, but using the \
> shared archive is done on a production environment. If there are many jars with a \
> complex build procedure,  ensure the same orders are difficult. 
> The patch first sorts the runtime classpath and dump classpath, then checks path \
> again.

test/hotspot/jtreg/runtime/cds/appcds/OutOfOrderClasspathTest.java line 49:

> 47:         String outputDir = CDSTestUtils.getOutputDir();
> 48:         System.setProperty("test.noclasspath", "true");
> 49:         String hiJar =  outputDir + File.separator + "hi.jar";

Suggestion:

        String hiJar = outputDir + File.separator + "hi.jar";

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17704#discussion_r1489140711


[prev in list] [next in list] [prev in thread] [next in thread]