[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-hotspot-runtime-dev
Subject:    Re: RFR: 8329850: [AIX] Allow loading of different members of same shared library archive [v5]
From:       Thomas Stuefe <stuefe () openjdk ! org>
Date:       2024-04-26 6:59:39
Message-ID: Y7X6G5zCsI99J1vJS0-5KQ7huaMwUKJod6-or-vvmGI=.34c2b5e8-9017-4eeb-875b-46dcb70c5455 () github ! com
[Download RAW message or body]

On Thu, 25 Apr 2024 14:43:52 GMT, Joachim Kern <jkern@openjdk.org> wrote:

> > With [JDK-8320890](https://bugs.openjdk.org/browse/JDK-8320890) we introduced the \
> > capability not to load shared libraries twice if the application wants to do \
> > that. Instead we just rise a ref counter. Unfortunately this also suppresses the \
> > loading of a second member of a shared library. This fix introduces an \
> > additionally stored hash value for each loaded member and only suppresses \
> > duplicate loading if the same member is loaded twice. If a shared library has no \
> > member a hash value of 0 is used to make the code orthogonal.
> 
> Joachim Kern has updated the pull request incrementally with one additional commit \
> since the last revision: 
> set ptr to nullptr after free

LGTM

-------------

Marked as reviewed by stuefe (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/18676#pullrequestreview-2024257003


[prev in list] [next in list] [prev in thread] [next in thread]