[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-hotspot-runtime-dev
Subject:    Re: RFR: 8315431: ArchiveHeapWriter::get_filler_size_at() cannot handle buffer expansion
From:       Matias Saavedra Silva <matsaave () openjdk ! org>
Date:       2024-04-25 15:26:34
Message-ID: I-Gzd7goS3oPoG208XLY9n1_F-LREY2uUJ2QMHik0So=.aba3f953-065c-4b83-bec2-ce84ae95aa4b () github ! com
[Download RAW message or body]

On Tue, 23 Apr 2024 15:47:46 GMT, Ioi Lam <iklam@openjdk.org> wrote:

> In `ArchiveHeapWriter::maybe_fill_gc_region_gap()`:
> 
> - The address of `filler` will change if the buffer (which is a GrowableArrayCHeap) \
>                 expands.
> - Instead of storing the address, we store the offset of `filler` from the \
> beginning of the buffer. This offset will not change even if the buffer expands.

LGTM!

-------------

Marked as reviewed by matsaave (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/18920#pullrequestreview-2022887647


[prev in list] [next in list] [prev in thread] [next in thread]