[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-hotspot-runtime-dev
Subject:    Re: RFR: 8330464: hserr generic events - add entry for the before_exit calls [v3]
From:       Matthias Baesken <mbaesken () openjdk ! org>
Date:       2024-04-24 12:58:35
Message-ID: mgfYBWRuXFFVlVqOD_JRmum12yYwIGipUxn_r3MhXPQ=.1e9e35bf-eb10-4209-b647-7992c5ce257e () github ! com
[Download RAW message or body]

On Thu, 18 Apr 2024 08:13:17 GMT, Matthias Baesken <mbaesken@openjdk.org> wrote:

> > We currently miss a hs_err file generic event entry for before_exit calls. Those \
> > would be helpful to see clearly that a crash happened in a shutdown phase (we had \
> > this case recently and would have liked to have a hserr event log entry showing \
> > this more clearly). 
> > Additionally while testing the event I called System.exit(0)  to check the event.
> > This showed a native backtrace like this 
> > 
> > Stack: [0x00007f1cfe825000,0x00007f1cfe926000],  sp=0x00007f1cfe924530,  free \
> > space=1021k Native frames: (J=compiled Java code, j=interpreted, Vv=VM code, \
> > C=native code) V  [libjvm.so+0x8fb21b]  before_exit(JavaThread*, bool)+0x4bb  \
> > (java.cpp:376) V  [libjvm.so+0x9da27c]  JVM_Halt+0x6c  (jvm.cpp:442)
> > j  java.lang.Shutdown.halt0(I)V+0 java.base@23.0.0.1-internal
> > j  java.lang.Shutdown.halt(I)V+7 java.base@23.0.0.1-internal
> > j  java.lang.Shutdown.exit(I)V+16 java.base@23.0.0.1-internal
> > j  java.lang.Runtime.exit(I)V+14 java.base@23.0.0.1-internal
> > j  java.lang.System.exit(I)V+4 java.base@23.0.0.1-internal
> > 
> > So the comment in thread.cpp seems to be outdated, Threads::destroy_vm()  is not \
> > in the callstack  and vm_exit() is not seen as well in the callstack so probably \
> > the comment needs adjustment.
> 
> Matthias Baesken has updated the pull request incrementally with one additional \
> commit since the last revision: 
> improve comment

Thanks for the reviews !

-------------

PR Comment: https://git.openjdk.org/jdk/pull/18809#issuecomment-2074882009


[prev in list] [next in list] [prev in thread] [next in thread]