[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-hotspot-runtime-dev
Subject:    Integrated: JDK-8327971: Multiple ASAN errors reported for metaspace
From:       Thomas Stuefe <stuefe () openjdk ! org>
Date:       2024-03-27 8:39:35
Message-ID: ue-SBpAihyQM8fR6rru-WiuHMd0FUANH0Fm4ea7Edd4=.f72d6a96-54b4-4dc2-904b-fa6cb02cc22c () github ! com
[Download RAW message or body]

On Tue, 12 Mar 2024 11:45:47 GMT, Thomas Stuefe <stuefe@openjdk.org> wrote:

> We have multiple issues that cause the ASAN build in fastdebug to not work, or to \
> fail gtests. 
> 1) When adding ASAN support for metaspace, we decided to track poisoning not at the \
> OS border (map) but at the border between metaspace and outer JVM code. More \
> precisely, at the border of ChunkManager chunk allocation/deallocation. Chunks \
> handed out by the chunk manager are unpoisoned and poisoned when handed back. 
> This causes some problems since within metaspace, we access memory that is \
> committed but not yet handed to the user (for zapping or for verification in debug \
> builds). So, from the ASANs' view, those accesses are invalid, whereas for \
> Metaspace, those accesses are perfectly valid. 
> In these cases, we need to unpoison the memory or exclude the code section, if \
> possible, for ASAN builds. This affects both JVM code and gtests. 
> 2) NMT gtests sometimes do dangerous things deliberately (accessing invalid memory \
> to track error recognition), and these tests should be disabled with ASAN

This pull request has now been integrated.

Changeset: 9e566d76
Author:    Thomas Stuefe <stuefe@openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/9e566d76d1d8acca27d8f69fffcbeb0b49b060ba
                
Stats:     50 lines in 9 files changed: 48 ins; 0 del; 2 mod

8327971: Multiple ASAN errors reported for metaspace
8327988: When running ASAN, disable dangerous NMT test

Reviewed-by: jsjolen, rkennke

-------------

PR: https://git.openjdk.org/jdk/pull/18230


[prev in list] [next in list] [prev in thread] [next in thread]