[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-hotspot-runtime-dev
Subject:    Re: RFR: JDK-8326496: [test] checkHsErrFileContent support printing hserr in error case [v3]
From:       Lutz Schmidt <lucy () openjdk ! org>
Date:       2024-02-29 16:27:53
Message-ID: _rNF7wdIE2qe8YRrGP0xmZjrOWbFQtyhiqYovb1349I=.49cb8aff-8c9e-496c-a01b-8d3ecfefc1c3 () github ! com
[Download RAW message or body]

On Fri, 23 Feb 2024 12:37:06 GMT, Matthias Baesken <mbaesken@openjdk.org> wrote:

> > checkHsErrFileContent checks hs error files for existance and non-existance of \
> > some user provided patterns. However it should also have an option to print the \
> > hs_err file in case of a failing check, this would make error analysis easier.
> 
> Matthias Baesken has updated the pull request incrementally with one additional \
> commit since the last revision: 
> adjust doc of verbose param

Looks good.

-------------

Marked as reviewed by lucy (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/17978#pullrequestreview-1909331192


[prev in list] [next in list] [prev in thread] [next in thread]