[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-hotspot-runtime-dev
Subject:    Re: RFR: 8324838: test_nmt_locationprinting.cpp broken in the gcc windows build [v2]
From:       Johan =?UTF-8?B?U2rDtmxlbg==?= <jsjolen () openjdk ! org>
Date:       2024-01-31 11:40:05
Message-ID: QpcfjUnODL7eO3EO4UD8EL0zgiMN3UXCyMMUXaWK_Bw=.35a311da-b009-4d7f-ae35-8c79810e69f3 () github ! com
[Download RAW message or body]

On Wed, 31 Jan 2024 10:15:06 GMT, Julian Waters <jwaters@openjdk.org> wrote:

> > test_nmt_locationprinting.cpp defines method test_for_dead_c_heap_block \
> > unconditionally, but this method is only ever used on Linux. In the gcc windows \
> > build this fires an unused method warning and breaks the gtest suite. Since this \
> > is never used outside of Linux, make this method's definition only appear on \
> > Linux to avoid polluting code on other platforms
> 
> Julian Waters has updated the pull request incrementally with one additional commit \
> since the last revision: 
> Copyright test_nmt_locationprinting.cpp

LGTM

-------------

Marked as reviewed by jsjolen (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/17612#pullrequestreview-1853527504


[prev in list] [next in list] [prev in thread] [next in thread]