[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-hotspot-runtime-dev
Subject:    Re: RFR: 8324893: Rename JVMDITools.h
From:       Kim Barrett <kbarrett () openjdk ! org>
Date:       2024-01-31 9:02:06
Message-ID: leDbBB732o6Y90IwqVyie4j3quQd8202zrNIiPWEmqY=.87338a1d-f129-4955-acfc-56df2b4e58a4 () github ! com
[Download RAW message or body]

On Tue, 30 Jan 2024 18:34:48 GMT, Kim Barrett <kbarrett@openjdk.org> wrote:

> 8324893: Rename JVMDITools.h
> 
> Please review this trivial change that renames the file
> test/hotspot/jtreg/vmTestbase/nsk/share/JVMDITools.h to JVMDITools.hpp.  There
> are no uses of NULL in this file to be fixed.
> 
> Testing: mach5 tier1

You are right. While looking into JDK-8324799 I found a couple of headers that
were only included by an associated .cpp that wasn't built, but the .cpp was
instead included by other files that were built. I mis-remembered this was one
of those, but apparently not. I'll delete the files, update the bug, and make a new PR.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/17636#issuecomment-1918662239
[prev in list] [next in list] [prev in thread] [next in thread]