[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-hotspot-runtime-dev
Subject:    Re: RFR: 8323994: gtest runner repeats test name for every single gtest assertion [v2]
From:       Thomas Stuefe <stuefe () openjdk ! org>
Date:       2024-01-25 14:44:32
Message-ID: ao5UZdf4BN7bifAS8Qa_ksBb7PTtbQicuJjmMfc_ETA=.fd239db6-0167-40b7-9a35-55177d6e5c16 () github ! com
[Download RAW message or body]

On Thu, 25 Jan 2024 14:20:59 GMT, Sonia Zaldana Calles <szaldana@openjdk.org> wrote:

> > If GTest fails multiple times within the same test (for example when EXPECT or \
> > ASSERT are used in a subroutine), `GTestResultParser` repeats the failing test \
> > multiple times in its report.  
> > Please refer to the existing issue for an example. 
> > 
> > We only need to see the failing test reported once, so this patch fixes that. 
> > 
> > Let me know your thoughts. 
> > Cheers, 
> > Sonia
> 
> Sonia Zaldana Calles has updated the pull request incrementally with one additional \
> commit since the last revision: 
> Fixing copyright header and spacing issue

Still good. Ship it.

-------------

PR Review: https://git.openjdk.org/jdk/pull/17489#pullrequestreview-1843904739


[prev in list] [next in list] [prev in thread] [next in thread]