[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-hotspot-runtime-dev
Subject:    Re: RFR: 8313083: Print 'rss' and 'cache' as part of the container information
From:       Poonam Bajaj <poonam () openjdk ! org>
Date:       2023-12-22 21:51:46
Message-ID: XLvdEqMi9_TcU2Juas2zk-R71o41gcpqMPUCzFglTII=.1457eab2-fe11-48e3-8b34-7aa9adba6ccb () github ! com
[Download RAW message or body]

On Tue, 19 Dec 2023 17:41:51 GMT, Gerard Ziemski <gziemski@openjdk.org> wrote:

> We add "rss" and "cache" metrics to cgroups v1 and v2
> 
> For cgroups v1, those metrics are named accordingly and are retrieved using the \
> same names. 
> For cgroups v2, those metrics seem not to be directly provided, but instead we \
>                 need:
> - `"anon"` for "rss"
> - `"file"` for "cache"
> 
> The cgroups v2 docs do not actually state this equivalence \
> (https://docs.kernel.org/admin-guide/cgroup-v2.html), but instead this comes from \
> reading cAdvisor src code - \
> https://github.com/google/cadvisor/blob/2129e1c4fae8567551d1ac252c7a1dec27617e21/container/libcontainer/handler.go#L814C4-L814C4
> 

The code changes look good to me. Thanks Gerard!

-------------

PR Comment: https://git.openjdk.org/jdk/pull/17161#issuecomment-1868090578


[prev in list] [next in list] [prev in thread] [next in thread]