[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-hotspot-runtime-dev
Subject:    Integrated: 8321683: Tests fail with AssertionError in RangeWithPageSize
From:       Stefan Karlsson <stefank () openjdk ! org>
Date:       2023-12-22 13:29:15
Message-ID: H3WpjNowBvtYRb_54m_uPv3T073L93M-5SFpidEXuFk=.10c56e7b-3ce7-4b76-9731-de5111d7d803 () github ! com
[Download RAW message or body]

On Mon, 11 Dec 2023 18:18:46 GMT, Stefan Karlsson <stefank@openjdk.org> wrote:

> The test was recently changed to check the THPeligible value in the smaps file, \
> instead of checking the hg flag. This was done because hg isn't set if the THP \
> policy is set to 'always'. With that change I added an assert that if the "hg" flag \
> is set, then THPeligible should also be set. This turns out to not be true, and the \
> assert fails. 
> My proposal is to check both properties and set isTHP to true if either is set. The \
> isTHP property is later only used to make the page size checks more lenient in the \
> presence of transparent huge pages.

This pull request has now been integrated.

Changeset: dce7a573
Author:    Stefan Karlsson <stefank@openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/dce7a5732e69b6d29f75b98f6cf58a567d353a59
                
Stats:     6 lines in 1 file changed: 0 ins; 1 del; 5 mod

8321683: Tests fail with AssertionError in RangeWithPageSize

Reviewed-by: stuefe, mbaesken

-------------

PR: https://git.openjdk.org/jdk/pull/17064


[prev in list] [next in list] [prev in thread] [next in thread]