[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-hotspot-runtime-dev
Subject:    Re: RFR: 8321933: TestCDSVMCrash.java spawns two processes
From:       Matias Saavedra Silva <matsaave () openjdk ! org>
Date:       2023-12-18 17:08:48
Message-ID: D4HYk6zeUEqOvLYlLBnhsFuAvN8b3qROVAx2lmTfqUs=.c1d01282-1cab-47ed-a3a5-60c37546c6ce () github ! com
[Download RAW message or body]

On Wed, 13 Dec 2023 21:55:12 GMT, Calvin Cheung <ccheung@openjdk.org> wrote:

> > TestCDSVMCrash.java looks like it spawns two processes, once in the pb.start() \
> > call and then again in executeAndLog: 
> > OutputAnalyzer output = new OutputAnalyzer(pb.start());
> > // executeAndLog should throw an exception in the VM crashed
> > try {
> > CDSTestUtils.executeAndLog(pb, "cds_vm_crash");
> > 
> > The test redundantly checks the result of the output since the expected exception \
> > will only be thrown if the checked conditions are true. 
> > Note that fixing the indentation makes the diff hard to read, so I recommend \
> > looking at each commit separately.
> 
> LGTM.

Thanks for the reviews @calvinccheung @iklam!

-------------

PR Comment: https://git.openjdk.org/jdk/pull/17092#issuecomment-1861071666


[prev in list] [next in list] [prev in thread] [next in thread]