[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-hotspot-runtime-dev
Subject:    Integrated: 8320826: call allocate_shared_strings_array after all strings are interned
From:       Ioi Lam <iklam () openjdk ! org>
Date:       2023-11-30 19:25:17
Message-ID: Aqz5XTJtqz0vBhv1z08l2-RC0QgUBrmIsIB7D6Q391Y=.6290c97a-7b9c-4ba5-8c75-95f89acfdfa9 () github ! com
[Download RAW message or body]

On Tue, 28 Nov 2023 04:09:52 GMT, Ioi Lam <iklam@openjdk.org> wrote:

> `StringTable::allocate_shared_strings_array()` creates a Java object array that has \
> the exact same size as the number of currently interned strings. Therefore, we need \
> to move it to just before we enter the safepoint, where we know no more Java code \
> would be execute. 
> I also had to change the assert in `StringTable::allocate_shared_strings_array()` \
> to a condition check:  it's possible for `HeapShared::init_for_dumping()` to \
> disable heap dumping when a Java agent transforms classes like \
> jdk.internal.math.FDBigInteger.

This pull request has now been integrated.

Changeset: 630bafd9
Author:    Ioi Lam <iklam@openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/630bafd9c66e7612d48c183c81a58ecbd6ea5866
                
Stats:     8 lines in 2 files changed: 6 ins; 1 del; 1 mod

8320826: call allocate_shared_strings_array after all strings are interned

Reviewed-by: ccheung, matsaave

-------------

PR: https://git.openjdk.org/jdk/pull/16839


[prev in list] [next in list] [prev in thread] [next in thread]