[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-hotspot-runtime-dev
Subject:    Re: RFR: 8320304: Refactor and simplify monitor deflation functions [v7]
From:       Stefan Karlsson <stefank () openjdk ! org>
Date:       2023-11-30 12:43:18
Message-ID: jnk74nSNCB5MNyMHYpa-RCMS-jKi7WcBT2HHAgW-Zl8=.ee9f8ba4-2a64-43f3-8acf-3a1b884557a9 () github ! com
[Download RAW message or body]

On Thu, 30 Nov 2023 10:35:41 GMT, Stefan Karlsson <stefank@openjdk.org> wrote:

> > The recent rewrites to remove safepointed monitor deflation allows us to simplify \
> > the monitor deflation code a bit. The code is now guaranteed to be called from \
> > the MonitorDeflationThread, which is a JavaThread, and never from the VMThread. 
> > I would like to propose two changes to the code:
> > 1) Remove all code that supports monitor deflation from other threads than the \
> > MonitorDeflationThread 2) Extract out the logging code so that it is easier to \
> > see the structure of the monitor deflation code 
> > I have run minimal manual of this patch. I'd like to get some feedback on the \
> > proposal before I proceed to run more in-depth testing.
> 
> Stefan Karlsson has updated the pull request with a new target base due to a merge \
> or a rebase. The pull request now contains ten commits: 
> - Small indentation correction
> - Merge remote-tracking branch 'upstream/master' into \
>                 8320304_cleanup_of_monitor_deflation
> - Small whitespace cleanups
> - Merge remote-tracking branch 'upstream/master' into \
>                 8320304_cleanup_of_monitor_deflation
> - Merge remote-tracking branch 'upstream/master' into \
>                 8320304_cleanup_of_monitor_deflation
> - David's review comments
> - Dan's review comments
> - Make classes StackObjs
> - 8320304: Refactor and simplify monitor deflation functions

Thanks for the reviews!

-------------

PR Comment: https://git.openjdk.org/jdk/pull/16706#issuecomment-1833699911


[prev in list] [next in list] [prev in thread] [next in thread]