[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-hotspot-runtime-dev
Subject:    Withdrawn: 8313708: NMT: cleanup _mst_marker
From:       duke <duke () openjdk ! org>
Date:       2023-10-26 19:36:44
Message-ID: R97EpTsKHfI2DpB-GQPPf4aqEiL43gVTbzaaPwZRnq4=.c13e33f4-8639-4bcf-b7ce-000f0c154f8d () github ! com
[Download RAW message or body]

On Thu, 3 Aug 2023 18:44:43 GMT, Gerard Ziemski <gziemski@openjdk.org> wrote:

> While learning the NMT code I came across _mst_marker and I don't really like how \
> it combines 16bit index and 16bit position into single 32bit mst_marker using bit \
> sizzling. 
> Consequently, right now we need the following 3 APIs: build_marker(), \
> bucket_idx_from_marker(), pos_idx_from_marker() to support this. They are really \
> not adding any value, in my opinion, and in fact obfuscate the code. 
> I'd like to propose that we simplify the code and pass a struct value (as suggested \
> by Thomas) which hides away the 2 individual fields that are implementation detail.

This pull request has been closed without being integrated.

-------------

PR: https://git.openjdk.org/jdk/pull/15145


[prev in list] [next in list] [prev in thread] [next in thread]