[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-hotspot-runtime-dev
Subject:    Re: RFR: 8304931: vm/concepts/methods/methods001/methods00101m1/methods00101m1 failures with
From:       Matias Saavedra Silva <matsaave () openjdk ! org>
Date:       2023-03-27 22:15:43
Message-ID: 7uxZR0KBXlPu_pVqlGJyud34J_-sm8V_o6X_o5UXSk0=.ccdc79f0-a5e2-468d-bbc5-b6096560709a () github ! com
[Download RAW message or body]

On Mon, 27 Mar 2023 21:32:21 GMT, Coleen Phillimore <coleenp@openjdk.org> wrote:

> > The change in [JDK-8304069](https://bugs.openjdk.org/browse/JDK-8304069) resulted \
> > in an assertion failure in the case of multiple duplicate fields, methods, or \
> > interfaces. This would create unwanted pending exceptions leading to a failure \
> > later. 
> > The method will now return following a class file parse error to avoid adding \
> > more pending errors. Verified with tiers 1-6.
> 
> Looks good plus trivial.

Thank you for the reviews @coleenp and @dholmes-ora

-------------

PR Comment: https://git.openjdk.org/jdk/pull/13195#issuecomment-1485926067


[prev in list] [next in list] [prev in thread] [next in thread]