[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-hotspot-runtime-dev
Subject:    Re: RFR: 8256302: releasing oopStorage when deflating allows for faster deleting
From:       David Holmes <dholmes () openjdk ! org>
Date:       2022-11-30 22:14:00
Message-ID: aNXBhjZXX4GdqSiWM6lz612UGsmCUF-3l03bMZ8N0eM=.540db6a9-e7d0-4a31-83c5-bcc53123a8ca () github ! com
[Download RAW message or body]

On Tue, 22 Nov 2022 17:52:45 GMT, Daniel D. Daugherty <dcubed@openjdk.org> wrote:

> Releasing ObjectMonitor oopStorage earlier when deflating allows ObjectMonitor
> deletion by a JavaThread (usually the MonitorDeflationThread) to happen while a
> ThreadBlockInVM helper is in place. This should improve time-to-safepoint.

I still think we should have been able to keep the release in the destructor guarded \
by some check:

if (! already_released) {
  assert(!safepoint_safe, "must be");
  _object.release(_oop_storage);
}

but perhaps there is no way to ask if "already_released"?

Thanks for the additional comments on the why of all this. The constraints on when \
you can access oopStorage were not clear before.

-------------

PR: https://git.openjdk.org/jdk/pull/11296


[prev in list] [next in list] [prev in thread] [next in thread]