[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-hotspot-runtime-dev
Subject:    RFR: 8297606: [AIX] Broken build after JDK-8295475
From:       Tyler Steele <tsteele () openjdk ! org>
Date:       2022-11-30 21:49:48
Message-ID: tOUFzk4gOL6U4kE_-8EXG_Cr7cn7lpV7VjKnqYvCfvg=.a0ce1473-a164-4c75-a75e-a35db6f59689 () github ! com
[Download RAW message or body]

Recent changes (https://github.com/openjdk/jdk/pull/10745) to ResourceObj, have \
caused the build to fail on AIX. This is because the AIX compiler (xlclang++) \
complains if 'operator new' is called on a class where 'operator delete' is marked as \
deleted (ie. `operator delete(void*) = delete`). This is the case even when 'operator \
new' is explicitly defined.

It is my understanding that future PRs will migrate many instances of ResourceObj to \
AnyObj (or other classes), so it's possible this work-around could be removed in the \
future. An alternate solution is to change ResouceObj to AnyObj in 61 places. This \
alternative solution works since AnyObj defines both 'operator new' and 'operator \
delete'. This is both a much bigger change, and doesn't provide any additional \
benefit if instances of ResourceObj are being reviewed anyway.

-------------

Commit messages:
 - Remove trailing whitespace
 - Fix issue related to deleted functions in xlc

Changes: https://git.openjdk.org/jdk/pull/11443/files
 Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=11443&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8297606
  Stats: 14 lines in 1 file changed: 12 ins; 0 del; 2 mod
  Patch: https://git.openjdk.org/jdk/pull/11443.diff
  Fetch: git fetch https://git.openjdk.org/jdk pull/11443/head:pull/11443

PR: https://git.openjdk.org/jdk/pull/11443


[prev in list] [next in list] [prev in thread] [next in thread]