[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-hotspot-runtime-dev
Subject:    Re: RFR: 8297284: ResolutionErrorTable's key is wrong [v2]
From:       Coleen Phillimore <coleenp () openjdk ! org>
Date:       2022-11-30 13:15:24
Message-ID: Mkx11w0GlgbULznNXg77WJDTcEAOSaeg1kCdqyldnrY=.c4ae8b23-4a33-4716-b8f0-195f83b3311e () github ! com
[Download RAW message or body]

On Mon, 21 Nov 2022 18:04:00 GMT, Coleen Phillimore <coleenp@openjdk.org> wrote:

> > The resolution error table had a trick for the lookup key of adding constant pool \
> > index into constant pool address because that key was assumed to be in the range \
> > of the constant pool, so unique.  For failed indy resolution, we also use the \
> > resolution error table and the index is not relative to the constant pool, so the \
> > key is potentially not unique.  Created a Key class for the table and moved the \
> > cpool and index into that.  Now the ResolutionErrorEntry just has the messages. 
> > Tested tier1-4.
> 
> Coleen Phillimore has updated the pull request incrementally with one additional \
> commit since the last revision: 
> Matias comments

Thank you Matias and Ioi!

-------------

PR: https://git.openjdk.org/jdk/pull/11244


[prev in list] [next in list] [prev in thread] [next in thread]