[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-hotspot-runtime-dev
Subject:    Re: RFR: 8287352: DockerTestUtils::execute shows incorrect elapsed time [v2]
From:       Ioi Lam <iklam () openjdk ! java ! net>
Date:       2022-05-27 4:34:45
Message-ID: bLLDy2RDVG7wfluZfBcdO68kaNmDe01C4R39vZl2n64=.9d6baa30-f86b-4cfa-8928-abf4acd382a4 () github ! com
[Download RAW message or body]

On Thu, 26 May 2022 08:58:13 GMT, Thomas Stuefe <stuefe@openjdk.org> wrote:

> > Ioi Lam has updated the pull request incrementally with one additional commit \
> > since the last revision: 
> > Renamed trimLines() -> limitLines()
> 
> Looks good.
> 
> I was confused btw by the name `trimLines` since that indicates that the lines \
> where whitespace trimmed when in fact it just returns the first n lines from the \
> input. Maybe rename that function? If you do, I don't need another review. 
> Thanks, Thomas

Thanks @tstuefe and @mseledts for the review.

-------------

PR: https://git.openjdk.java.net/jdk/pull/8897


[prev in list] [next in list] [prev in thread] [next in thread]