[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-hotspot-runtime-dev
Subject:    Re: RFR: JDK-8285712: LogMessageBuffer doesn't check vsnprintf return value [v3]
From:       Ioi Lam <iklam () openjdk ! java ! net>
Date:       2022-04-29 18:44:40
Message-ID: nDVW3Bj5OjwdT5wcor28-ne1yYKyI_StfgRbMpV6K7s=.61dfe5bd-2251-4db0-8f7d-fa0196b3c1f8 () github ! com
[Download RAW message or body]

On Fri, 29 Apr 2022 07:52:34 GMT, Johan Sjölén <duke@openjdk.java.net> wrote:

> > os::vsnprintf can return a negative value on encoding error. A negative return \
> > value will cause wraparound when cast to size_t. This in turn causes \
> > LogMessageBuffer::grow() to attempt a large memory allocation. Instead of \
> > accepting this we bail on the logging.
> 
> Johan Sjölén has updated the pull request incrementally with one additional \
> commit since the last revision: 
> Print the assertion error message to the log

Marked as reviewed by iklam (Reviewer).

-------------

PR: https://git.openjdk.java.net/jdk/pull/8423


[prev in list] [next in list] [prev in thread] [next in thread]