[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-hotspot-runtime-dev
Subject:    Re: RFR: 8285828: runtime/execstack/TestCheckJDK.java fails with zipped debug symbols
From:       Jie Fu <jiefu () openjdk ! java ! net>
Date:       2022-04-29 8:55:44
Message-ID: cNXtXgpF0MXqAzfQOv9lFi_K368WL6Q4P1YtLX_UzTM=.28cdbb92-f7a2-4b53-9b5e-16a63365dc18 () github ! com
[Download RAW message or body]

On Fri, 29 Apr 2022 04:37:22 GMT, David Holmes <dholmes@openjdk.org> wrote:

> > Hi all,
> > 
> > If we configure and build the jdk with `--with-native-debug-symbols=zipped`, \
> > `runtime/execstack/TestCheckJDK.java` fails on Linux. 
> > The failure was caused by the following zipped debug symbols files, which aren't \
> > ELF files at all. 
> > ~/jdk/build/linux-x86_64-server-release/images/jdk/bin]$ ls *.diz
> > jar.diz        java.diz     jcmd.diz      jdeprscan.diz  jhsdb.diz   jlink.diz  \
> > jpackage.diz    jshell.diz  jstat.diz       rmiregistry.diz jarsigner.diz  \
> > javadoc.diz  jconsole.diz  jdeps.diz      jimage.diz  jmap.diz   jps.diz         \
> > jstack.diz  jwebserver.diz  serialver.diz javac.diz      javap.diz    jdb.diz     \
> > jfr.diz        jinfo.diz   jmod.diz   jrunscript.diz  jstatd.diz  keytool.diz 
> > 
> > The fix just skips these non-elf `*.diz` files when checking the linking \
> > attributes. 
> > Thanks.
> > Best regards,
> > Jie
> 
> Looks good.
> 
> Thanks,
> David

Thanks @dholmes-ora and @tstuefe for the review.

-------------

PR: https://git.openjdk.java.net/jdk/pull/8451


[prev in list] [next in list] [prev in thread] [next in thread]