[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-hotspot-runtime-dev
Subject:    Re: RFR: 8285279: ArgumentsTest.set_numeric_flag_double_vm fails on some locales (again)
From:       Ioi Lam <iklam () openjdk ! java ! net>
Date:       2022-04-27 5:02:40
Message-ID: lgORVzlKECsmtUrd2Zb5pmF2lRTmjpbpmS9KqUbD_lI=.09128f09-5230-4285-8a7a-9c3ad4aa0b44 () github ! com
[Download RAW message or body]

On Tue, 26 Apr 2022 00:09:46 GMT, David Holmes <dholmes@openjdk.org> wrote:

> > Please review this trivial fix for ArgumentsTest.set_numeric_flag_double_vm. If \
> > an input string is only partially accepted by `strtod()` under the current locale \
> > , `end` will point to a non-empty character. In this case, the test should treat \
> > the input as invalid. 
> > Thanks to @tstuefe for providing the test scenario.
> 
> Marked as reviewed by dholmes (Reviewer).

Thanks @dholmes-ora for the review.

-------------

PR: https://git.openjdk.java.net/jdk/pull/8386


[prev in list] [next in list] [prev in thread] [next in thread]